Re: [Intel-gfx] [PATCH] drm/i915/gt: Manage uncore->lock while waiting on MCR register

[John Harrison <john.c.harrison@xxxxxxxxx>]

On 11/17/2022 09:33, Matt Roper wrote:
> ...
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> index 830edffe88cc..d9a8ff9e5e57 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> @@ -730,17 +730,19 @@ void intel_gt_mcr_get_ss_steering(struct intel_gt *gt, unsigned int dss,
>    *
>    * Return: 0 if the register matches the desired condition, or -ETIMEDOUT.
>    */
> -int intel_gt_mcr_wait_for_reg_fw(struct intel_gt *gt,
> -				 i915_mcr_reg_t reg,
> -				 u32 mask,
> -				 u32 value,
> -				 unsigned int fast_timeout_us,
> -				 unsigned int slow_timeout_ms)
> +int intel_gt_mcr_wait_for_reg(struct intel_gt *gt,
This change missed the comment above and so is causing errors from the 
documentation build:

Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead
./drivers/gpu/drm/i915/gt/intel_gt_mcr.c:739: warning: expecting prototype for intel_gt_mcr_wait_for_reg_fw(). Prototype was for intel_gt_mcr_wait_for_reg() instead

John.