> -----Original Message----- > From: Fabio Estevam <festevam@xxxxxxxxx> > Sent: 2022年11月23日 2:09 > To: Sandor Yu <sandor.yu@xxxxxxx> > Cc: andrzej.hajda@xxxxxxxxx; neil.armstrong@xxxxxxxxxx; > robert.foss@xxxxxxxxxx; Laurent.pinchart@xxxxxxxxxxxxxxxx; > jonas@xxxxxxxxx; jernej.skrabec@xxxxxxxxx; airlied@xxxxxxxxx; > daniel@xxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kishon@xxxxxx; > vkoul@xxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx; > alexander.stein@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx>; Oliver Brown <oliver.brown@xxxxxxx> > Subject: [EXT] Re: [PATCH v4 01/10] drm: bridge: cadence: convert mailbox > functions to macro functions > > Caution: EXT Email > > Hi Sandor, > > On Mon, Nov 21, 2022 at 4:27 AM Sandor Yu <Sandor.yu@xxxxxxx> wrote: > > > > Mailbox access functions could be share to other mhdp driver and > > HDP-TX HDMI/DP PHY drivers, move those functions to head file > > include/drm/bridge/cdns-mhdp-mailbox.h and convert them to macro > > functions. > > What is the reason for converting the functions to macro? Both HDMI PHY driver and HDMI bridge driver need mailbox API function to access register and get status from firmware. Covert those functions to macro could be easy reused by both PHY and bridge driver. B.R Sandor
