On 11/18/22 14:48, Thomas Zimmermann wrote: [...] >>> >> >> Ah, I see. So is to set 32-bit bpp for both XRGB8888 and ARGB8888. But then >> I think that you also need to fix logicvc_mode_init() to remove that += 8? >> >> Because right now the preferred_depth += 8 would set a preferred_depth of 32 >> when should be just 24 even if alpha is enabled? >> >> Or am I confusing again the meaning of the color depth? > > For DRM, it's defined in drm_fourcc.c. ARGB8888 has a depth of 32 and > XRGB8888 has a depth of 24. Both have a bpp of 32. > > BUT in logicvc's internal data structure, both formats have a color > depth of 24 and a bpp of 32. > Got it. Thanks for the explanations and sorry for the silly questions then. If you drop that 15-bit preferred depth case, feel free to add Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
