RE: [EXT] Re: [PATCH v3 05/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ

[Sandor Yu <sandor.yu@xxxxxxx>]

Hi Rob,

Thanks your comments,

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2022年11月17日 0:27
> To: Sandor Yu <sandor.yu@xxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-phy@xxxxxxxxxxxxxxxxxxx; andrzej.hajda@xxxxxxxxx;
> neil.armstrong@xxxxxxxxxx; robert.foss@xxxxxxxxxx;
> Laurent.pinchart@xxxxxxxxxxxxxxxx; jonas@xxxxxxxxx;
> jernej.skrabec@xxxxxxxxx; vkoul@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; tzimmermann@xxxxxxx; lyude@xxxxxxxxxx;
> javierm@xxxxxxxxxx; ville.syrjala@xxxxxxxxxxxxxxx; sam@xxxxxxxxxxxx;
> jani.nikula@xxxxxxxxx; maxime@xxxxxxxxxx;
> penguin-kernel@xxxxxxxxxxxxxxxxxxx; Oliver Brown <oliver.brown@xxxxxxx>
> Subject: [EXT] Re: [PATCH v3 05/10] dt-bindings: display: bridge: Add MHDP
> DP for i.MX8MQ
> 
> Caution: EXT Email
> 
> On Tue, Nov 08, 2022 at 09:00:08PM +0800, Sandor Yu wrote:
> > Add bindings for i.MX8MQ MHDP DisplayPort.
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx>
> > ---
> >  .../display/bridge/cdns,mhdp-imx8mq-dp.yaml   | 59
> +++++++++++++++++++
> >  1 file changed, 59 insertions(+)
> >  create mode 100644
> >
> Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp.y
> > aml
> >
> > diff --git
> >
> a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp
> > .yaml
> >
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-dp
> > .yaml
> > new file mode 100644
> > index 000000000000..c4d5362db2b5
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8m
> > +++ q-dp.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp-imx8mq-dp.
> yaml%
> >
> +23&amp;data=05%7C01%7CSandor.yu%40nxp.com%7Cfadde1cdcefe4c1e5f
> b108dac
> >
> +7ef642f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63804212
> 82331650
> >
> +96%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luM
> zIiLCJBTi
> >
> +I6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=EjvtnWhP
> MVKgzlKC7f
> > +8GC3EtidDKgkU5vMSuRaz3Bqg%3D&amp;reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7CSa
> ndor.yu
> >
> +%40nxp.com%7Cfadde1cdcefe4c1e5fb108dac7ef642f%7C686ea1d3bc2b4c
> 6fa92cd
> >
> +99c5c301635%7C0%7C0%7C638042128233165096%7CUnknown%7CTWFp
> bGZsb3d8eyJW
> >
> +IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C3000
> >
> +%7C%7C%7C&amp;sdata=l0tVYsOuT6SNbREcg65s0FYjVVrpUM%2F5VztRvxE
> sgA8%3D&
> > +amp;reserved=0
> > +
> > +title: Cadence MHDP Displayport bridge
> > +
> > +maintainers:
> > +  - Sandor Yu <Sandor.yu@xxxxxxx>
> > +
> > +description:
> > +  The Cadence MHDP Displayport TX interface.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - cdns,mhdp-imx8mq-dp
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  phys:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Hotplug detect interrupter for cable plugin event.
> > +      - description: Hotplug detect interrupter for cable plugout event.
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: plug_in
> > +      - const: plug_out
> > +
> > +  port:
> > +    $ref: /schemas/graph.yaml#/properties/port
> > +    description:
> > +      A port node pointing to the output port of a display controller.
> 
> Similarly, you need an output port to DP (or USB-C) connector.
> 
Both the HDMI and DP driver don't need the functions of display-connector, 
do we still need an output port to connector here?

B.R
Sandor

> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    mhdp_dp: dp-bridge@32c00000 {
> > +        compatible = "cdns,mhdp-imx8mq-dp";
> > +        reg = <0x32c00000 0x100000>;
> > +        interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> > +                <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > +        interrupt-names = "plug_in", "plug_out";
> > +        phys = <&dp_phy>;
> > +
> > +        port {
> > +            mhdp_in: endpoint {
> > +                remote-endpoint = <&dcss_out>;
> > +            };
> > +        };
> > +    };
> > --
> > 2.34.1
> >
> >