Hi Gil: Gil Dekel <gildekel@xxxxxxxxxxxx> 於 2022年11月11日 週五 凌晨2:49寫道： > > [Why] > Some userspaces assume that the first connected connector is the "main" > display, which supposed to display, for example, the login screen. > For laptops, this should be the internal connector. > > [How] > This patch calls drm_helper_move_panel_connectors_to_head() right before > crtc creation to ensure internal connectors are at the top of the > connector list. > > Tested by ensuring the internal panels are at the top of the connector > list via modetest -c. > > This patch does to mediatek what the following patch > https://www.spinics.net/lists/stable/msg590605.html > did for qualcomm. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Gil Dekel <gildekel@xxxxxxxxxxxx> > Tested-by: Gil Dekel <gildekel@xxxxxxxxxxxx> > --- > v2: Fix copy-paste errors in commit message so it's relevant for this > patch and the mediatek driver. > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 91f58db5915f..76daaf6a0945 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -386,6 +386,12 @@ static int mtk_drm_kms_init(struct drm_device *drm) > if (ret) > goto put_mutex_dev; > > + /* > + * Ensure internal panels are at the top of the connector list before > + * crtc creation. > + */ > + drm_helper_move_panel_connectors_to_head(drm); > + > /* > * We currently support two fixed data streams, each optional, > * and each statically assigned to a crtc: > -- > Gil Dekel, Software Engineer, Google / ChromeOS Display and Graphics
