Re: [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/11/2022 14:05, Krzysztof Kozlowski wrote:
On 24/10/2022 18:42, Dmitry Baryshkov wrote:
Move properties common to all MDSS DT nodes to the mdss-common.yaml.

This extends qcom,msm8998-mdss schema to allow interconnect nodes, which
will be added later, once msm8998 gains interconnect support.


(...)

+    minItems: 1
+    items:
+      - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
+      - description: Interconnect path from mdp1 port to the data bus
+
+  interconnect-names:
+    minItems: 1
+    items:
+      - const: mdp0-mem
+      - const: mdp1-mem
+
+  resets:
+    items:
+      - description: MDSS_CORE reset
+
+required:
+  - compatible

For consistency this should not be required here, but in schema actually
defining it.

+  - reg
+  - reg-names
+  - power-domains
+  - clocks
+  - interrupts
+  - interrupt-controller
+  - iommus
+  - ranges

Keep the same order as in list of top-level properties.

But the order is the same.

Compare:
  reg:
  reg-names:
  power-domains:
  clocks:
  clock-names:
  interrupts:
  interrupt-controller: true
  iommus:
  ranges: true
  interconnects:
  interconnect-names:
  resets:

I'll add clock-names, but the rest is correct (interconnects and resets are optional).


+
+additionalProperties: true

Best regards,
Krzysztof


--
With best wishes
Dmitry




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux