On Fri, Nov 4, 2022 at 11:04 PM Antonio Gomes <antoniospg100@xxxxxxxxx> wrote:
>
> From: antoniospg <antoniospg100@xxxxxxxxx>
>
> Summary:
>
> * Add support to turn on/off backlight when changing values in bl_power
> file. This is achieved by using function backlight_get_brightness()
> in nva3_set_intensity to get current brightness.
>
> Test plan:
>
> * Turn off:
> echo 1 > /sys/class/backlight/nv_backlight/bl_power
>
> * Turn on:
> echo 0 > /sys/class/backlight/nv_backlight/bl_power
>
> Signed-off-by: antoniospg <antoniospg100@xxxxxxxxx>
> ---
> drivers/gpu/drm/nouveau/nouveau_backlight.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_backlight.c b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> index a2141d3d9b1d..5c82f5189b79 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_backlight.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_backlight.c
> @@ -263,7 +263,11 @@ nva3_set_intensity(struct backlight_device *bd)
> u32 div, val;
>
> div = nvif_rd32(device, NV50_PDISP_SOR_PWM_DIV(or));
> - val = (bd->props.brightness * div) / 100;
> +
> + val = backlight_get_brightness(bd);
> + if (val)
> + val = (val * div) / 100;
> +
> if (div) {
> nvif_wr32(device, NV50_PDISP_SOR_PWM_CTL(or),
> val |
> --
> 2.25.1
>
Reviewed-by: Karol Herbst <kherbst@xxxxxxxxxx>
btw, i'll fix up the name with the one from the Email From field, so
you won't have to send it out again.
