On Mon, Nov 7, 2022 at 6:25 PM Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> wrote: > > On 11/6/2022 2:02 PM, Oded Gabbay wrote: > > > @@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev, > > /* no per-device feature limits by default */ > > dev->driver_features = ~0u; > > > > + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) && > > + (drm_core_check_feature(dev, DRIVER_RENDER) || > > + drm_core_check_feature(dev, DRIVER_MODESET))) { > > Shouldn't the indentation for the 2nd and 3rd line be such that the > start of the lines is aligned with the "(" on the first line? afaik there is no such rule. If there was, checkpatch should have reported that. Oded