Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

[Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>]

On 04/11/2022 14:13, Dmitry Baryshkov wrote:
> From: Vinod Koul <vkoul@xxxxxxxxxx>
>
> Add the HDMI display nodes and link it to DSI. Also enable missing dispcc
> nodes
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 45 +++++++++++++++++++++++++
>   1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 9522dd29a38a..f37f226e9b11 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -20,6 +20,17 @@ chosen {
>   		stdout-path = "serial0:115200n8";
>   	};
>   
> +	hdmi-out {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con: endpoint {
> +				remote-endpoint = <&lt9611_out>;
> +			};
> +		};
> +	};
> +
>   	lt9611_1v2: lt9611-vdd12-regulator {
>   		compatible = "regulator-fixed";
>   		regulator-name = "LT9611_1V2";
> @@ -389,6 +400,26 @@ lt9611_codec: hdmi-bridge@2b {
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&lt9611_irq_pin &lt9611_rst_pin>;
>   
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +
> +				lt9611_a: endpoint {
> +					remote-endpoint = <&dsi0_out>;
> +				};
> +			};
> +
> +			port@2 {
> +				reg = <2>;
> +
> +				lt9611_out: endpoint {
> +					remote-endpoint = <&hdmi_con>;
> +				};
> +			};
> +		};
>   	};
>   };
>   
> @@ -512,9 +543,23 @@ &mdss_mdp {
>   	status = "okay";
>   };
>   
> +&dispcc {
> +	status = "okay";
> +};

Please sort this alphabetically (though I think it's gonna be ok after 
you fix it in 3/5).


With that:


Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>


Konrad

> +
>   &dsi0 {
>   	status = "okay";
>   	vdda-supply = <&vreg_l6b_1p2>;
> +
> +	ports {
> +		port@1 {
> +			endpoint {
> +				remote-endpoint = <&lt9611_a>;
> +				data-lanes = <0 1 2 3>;
> +			};
> +		};
> +	};
> +
>   };
>   
>   &dsi0_phy {