On Thu, Nov 03, 2022 at 11:26:09AM +0800, Nancy.Lin wrote: > Add drm ovl_adaptor sub driver. Bring up ovl_adaptor sub driver if > the component exists in the path. > > Signed-off-by: Nancy.Lin <nancy.lin@xxxxxxxxxxxx> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > Tested-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx> > Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> > Change-Id: I0501f3c80e78ec8279366cba9c137a2edd7a852e > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 61 ++++----- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 129 ++++++++++++-------- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 50 +++++++- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 78 ++++++------ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 12 +- > 6 files changed, 209 insertions(+), 123 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index 30dcb65d8a5a..ce5617ad04cb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c [..] > int mtk_drm_crtc_create(struct drm_device *drm_dev, > - const enum mtk_ddp_comp_id *path, unsigned int path_len, > + const unsigned int *path, unsigned int path_len, Hi Nancy, why is 'enum mtk_ddp_comp_id' being changed to 'unsigned int' throughout this patch? Was this intentional? I saw that this change happened between v16 [1] and v17 [2], but I didn't see any reply or mention about this in the commit message or cover letter. Thanks, Nícolas [1] https://lore.kernel.org/all/20220318142009.2796-21-nancy.lin@xxxxxxxxxxxx/ [2] https://lore.kernel.org/all/20220416020749.29010-20-nancy.lin@xxxxxxxxxxxx/