Re: [PATCH v2 1/2] drm/ofdrm: Convert PCI IDs to CPU endianness for comparing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/28/22 14:22, Thomas Zimmermann wrote:
> Properties of 32-bit integers are returned from the OF device tree
> as type __be32. Convert PCI vendor and device IDs from __be32 to host
> endianness before comparing them to constants. All relevant machines
> are old, big-endian Macintosh systems; hence the bug never happened
> in practice.
> 
> Fixes sparse warnings shown below.
> 
>   drivers/gpu/drm/tiny/ofdrm.c:237:17: warning: restricted __be32 degrades to integer
>   drivers/gpu/drm/tiny/ofdrm.c:238:18: warning: restricted __be32 degrades to integer
>   drivers/gpu/drm/tiny/ofdrm.c:238:54: warning: restricted __be32 degrades to integer
> 
> See [1] for the bug report.
> 
> v2:
> 	* convert endianness (Alex)
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Link: https://lore.kernel.org/dri-devel/202210192208.D888I6X7-lkp@xxxxxxxxx/ # [1]
> ---

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux