On 10/31/22 23:32, antoniospg wrote: > Summary: > > * Add support to turn on/off backlight when changing values in bl_power > file. This is achieved by using function backlight_get_brightness() > in nva3_set_intensity to get current brightness. > This is [PATCH v2], right? If so, next time please pass -v <version number> to git-format-patch(1). Also, just say the prose without using bullet list. "Summary:" line is also redundant. And again, please describe why this change be made. > Test plan: > > * Turn off: > echo 1 > /sys/class/backlight/nv_backlight/bl_power > > * Turn on: > echo 0 > /sys/class/backlight/nv_backlight/bl_power > Shouldn't "test plan" above be documented in Documentation/ instead? Last but not least, is "antoniospg" your real, legal name? Thanks. -- An old man doll... just what I always wanted! - Clara
