Hi Grillo :)
On 10/26/22 18:14, Arthur Grillo wrote:
As reported by Michał the drm_mm and drm_buddy unit tests lost the
printk with seed value after they being refactored into kunit. This
patch adds back this important information to assure reproducibility
converting them to use the kunit api.
You should write you commit message in imperative form, like "Add back
this important [...]"
Signed-off-by: Arthur Grillo <arthurgrillo@xxxxxxxxxx>
Reported-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>
---
drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
drivers/gpu/drm/tests/drm_mm_test.c | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
index 62f69589a72d..83c8863bc643 100644
--- a/drivers/gpu/drm/tests/drm_buddy_test.c
+++ b/drivers/gpu/drm/tests/drm_buddy_test.c
@@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test)
while (!random_seed)
random_seed = get_random_u32();
+ kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
DRM buddy manager (struct drm_buddy)
seems a bit redundant to me.
+ random_seed);
+
return 0;
}
diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
index c4b66eeae203..492347069d58 100644
--- a/drivers/gpu/drm/tests/drm_mm_test.c
+++ b/drivers/gpu/drm/tests/drm_mm_test.c
@@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test)
while (!random_seed)
random_seed = get_random_u32();
+ kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
+ random_seed, max_iterations, max_prime);
+
return 0;
}
@@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = {
};
kunit_test_suite(drm_mm_test_suite);
-
MODULE_AUTHOR("Intel Corporation");
MODULE_LICENSE("GPL");
