On 26/10/2022 14:21, Tomi Valkeinen wrote:
On 24/10/2022 18:39, Dmitry Baryshkov wrote:
From all the drivers using drm_bridge_connector only iMX/dcss and OMAP
DRM driver do a proper work of calling
drm_bridge_connector_en/disable_hpd() in right places. Rather than
teaching each and every driver how to properly handle
drm_bridge_connector's HPD, make that automatic.
Add two additional drm_connector helper funcs: enable_hpd() and
disable_hpd(). Make drm_kms_helper_poll_* functions call them (as this
is the time where the drm_bridge_connector's functions are called by the
drivers too).
Changes since v1:
- Rebased on top of v6.1-rc1
- Removed the drm_bridge_connector_enable_hpd() from
drm_bridge_connector_init()
- Removed extra underscore prefix from
drm_bridge_connector_en/disable_hpd() helpers
Dmitry Baryshkov (7):
drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini()
drm/probe-helper: enable and disable HPD on connectors
drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement
drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd()
drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()
drm/omap: stop using drm_bridge_connector_en/disable_hpd()
drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd()
drivers/gpu/drm/drm_bridge_connector.c | 27 +++-------------
drivers/gpu/drm/drm_probe_helper.c | 40 ++++++++++++++++++-----
drivers/gpu/drm/imx/dcss/dcss-dev.c | 4 ---
drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 --
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 --
drivers/gpu/drm/omapdrm/omap_drv.c | 41 ------------------------
include/drm/drm_bridge_connector.h | 2 --
include/drm/drm_modeset_helper_vtables.h | 22 +++++++++++++
8 files changed, 59 insertions(+), 81 deletions(-)
For the series:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
This fixes the issue (WARN for "Hot plug detection already enabled")
introduced by 09077bc3116581f4d1cb961ec359ad56586e370b, which you revert
in the third patch. You could mention this, maybe as a fixes tag and a
mention in the description.
I'll add it to the description. However I don't think it's a good idea
to add Fixes tag. It increases the chances of picking up this single
patch for the stable tree, which would disable the HPD notifications for
the non OMAP/iMX boards.
--
With best wishes
Dmitry
