Hi Rob, On Mon, Oct 24, 2022 at 08:48:15AM -0700, Rob Clark wrote: > On Mon, Oct 24, 2022 at 5:43 AM <maxime@xxxxxxxxxx> wrote: > > I've discussing the idea for the past year to add an IGT test suite that > > all well-behaved KMS drivers must pass. > > > > The main idea behind it comes from v4l2-compliance and cec-compliance, > > that are being used to validate that the drivers are sane. > > > > We should probably start building up the test list, and eventually > > mandate that all tests pass for all the new KMS drivers we would merge > > in the kernel, and be run by KCi or similar. > > Let's get https://patchwork.freedesktop.org/patch/502641/ merged > first, that already gives us a mechanism similar to what we use in > mesa to track pass/fail/flake I'm not sure it's a dependency per-se, and I believe both can (and should) happen separately. AFAIU, the CI patches are here to track which tests are supposed to be working and which aren't so that we can track regressions. The list I was talking about is here to identify issues in the first place. All tests must pass, and if one fails it should be considered a hard failure. This would be eligible for CI only for drivers which have been known to pass them all already, but we wouldn't need to track which ones can fail or not, all of them must. > Beyond that, I think some of the igt tests need to get more stable > before we could consider a "mustpass" list. I agree that IGT tests could get more stable on ARM platforms, but it's also a chicken-and-egg issue. If no-one is using them regularly on ARM, then they'll never get fixed. > The kms_lease tests seem to fail on msm due to bad assumptions in the > test about which CRTCs primary planes can attach to. The legacy-cursor > crc tests seem a bit racy (there was a patch posted for that, not sure > if it landed yet), etc. And this is fine, we can merge that list without them, and if and when they get stable, we'll add them later. > The best thing to do is actually start running CI and tracking xfails > and flakes ;-) Again, I wouldn't oppose them. The issue I'm trying to solve is that there's just no way to know, at the moment: - When you're running IGT, which tests are relevant for your platform exactly. - If some of them fail, is it expected for them to fail or not. The ci/ patch you mentioned help for that a bit, but only for platforms where someone already did that work. When you want to do that work in the first place, it's extremely tedious and obscure. - And if some of them fail, is it something that I should actually fix or not. The mustpass list addresses all those issues by providing a baseline. Maxime
