On Fri, 21 Oct 2022 at 15:24, Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote: > > On 10/21/22 16:18, Matti Vaittinen wrote: > > Simplify using devm_regulator_bulk_get_enable() > > > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx> > > Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx> > > Robert, I did slightly modify the return from probe when using the > dev_err_probe(). I still decided to keep your RBT - please let me know > if you disagree. Not a problem. In fact, feel free to upgrade it to an acked-by, to simplify merging this series. Acked-by: Robert Foss <robert.foss@xxxxxxxxxx> > > Eg, this: > > - if (ret < 0) { > > - dev_err_probe(dev, ret, "Failed to enable supplies"); > > - return ret; > > - } > > was converted to: > > if (ret < 0) > > + return dev_err_probe(dev, ret, "Failed to enable supplies"); > > Yours > -- Matti > > -- > Matti Vaittinen > Linux kernel developer at ROHM Semiconductors > Oulu Finland > > ~~ When things go utterly wrong vim users can always type :help! ~~ >