[AMD Official Use Only - General] Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Alex > Deucher > Sent: Thursday, October 20, 2022 10:36 PM > To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Thomas > Zimmermann <tzimmermann@xxxxxxx> > Subject: [PATCH] drm/amdgpu: don't call drm_fb_helper_lastclose in > lastclose() > > It's used to restore the fbdev console, but as amdgpu uses > generic fbdev emulation, the console is being restored by the > DRM client helpers already. See the call to drm_client_dev_restore() > in drm_lastclose(). > > Fixes: 087451f372bf76 ("drm/amdgpu: use generic fb helpers instead of > setting up AMD own's.") > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > index fe23e09eec98..474b9f40f792 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > @@ -1106,7 +1106,6 @@ int amdgpu_info_ioctl(struct drm_device *dev, > void *data, struct drm_file *filp) > */ > void amdgpu_driver_lastclose_kms(struct drm_device *dev) > { > - drm_fb_helper_lastclose(dev); > vga_switcheroo_process_delayed_switch(); > } > > -- > 2.37.3