Re: [PATCH v5 01/10] gna: add PCI driver module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 21, 2022 at 03:10:06PM +0700, Bagas Sanjaya wrote:
> On 10/21/22 11:20, Greg Kroah-Hartman wrote:
> > On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote:
> >> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator
> > 
> > Please drop all of the (R) stuff in here, and in the Kconfig file and in
> > the .c files.  If your lawyers insist on it, please point them at me and
> > I will be glad to discuss it with them.
> > 
> >>  Documentation/gpu/drivers.rst    |  1 +
> >>  Documentation/gpu/gna.rst        | 64 ++++++++++++++++++++++++++++++++
> > 
> > Why not just put the tiny documentation file in the .c code itself?
> > That way it stays up to date and might actually be noticed?
> > 
> 
> I think the documentation should be on separate patch.

Not if it is in the .c file.



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux