On Thu, Oct 20, 2022 at 07:53:32PM +0200, Maciej Kwapulinski wrote:
> From: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx>
>
> Although the patch adds GNA_WAIT ioctl, it's main purpose is to provide FIFO
> work-queue logic, which offloads each score operation in sequence to GNA
> accelerator. When it's done, process(es) WAITing for score to be finished are
> woken up.
I do not understand the "Although" here at all :(
> +static irqreturn_t gna_interrupt(int irq, void *priv)
> +{
> + struct gna_device *gna_priv;
> +
> + gna_priv = (struct gna_device *)priv;
> + gna_priv->dev_busy = false;
> + wake_up(&gna_priv->dev_busy_waitq);
> + return IRQ_HANDLED;
> +}
irq handling, nice! Why wan't that discussed in the changelog?
{sigh}
I'm stopping here, this needs lots of work to make it reviewable to
understand what is going on at all.
Please take the time and get proper internal-Intel review first, before
asking community members to take their time to tell you the things that
they should have already told you.
thanks,
greg k-h
