Re: [PATCH] Make xilinxfb_release() return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/19/22 15:24, Uwe Kleine-König wrote:
The function xilinxfb_release() returns zero unconditionally. Make it
return void. There is no semantic change, the only effect is that it
becomes obvious that the driver's .remove() callback always returns zero.

This is a preparation for making platform remove callbacks return void.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

applied, with the subject adjusted.

Thanks,
Helge


---
  drivers/video/fbdev/xilinxfb.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/xilinxfb.c b/drivers/video/fbdev/xilinxfb.c
index 438e2c78142f..1ac83900a21c 100644
--- a/drivers/video/fbdev/xilinxfb.c
+++ b/drivers/video/fbdev/xilinxfb.c
@@ -376,7 +376,7 @@ static int xilinxfb_assign(struct platform_device *pdev,
  	return rc;
  }

-static int xilinxfb_release(struct device *dev)
+static void xilinxfb_release(struct device *dev)
  {
  	struct xilinxfb_drvdata *drvdata = dev_get_drvdata(dev);

@@ -402,8 +402,6 @@ static int xilinxfb_release(struct device *dev)
  	if (!(drvdata->flags & BUS_ACCESS_FLAG))
  		dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
  #endif
-
-	return 0;
  }

  /* ---------------------------------------------------------------------
@@ -480,7 +478,9 @@ static int xilinxfb_of_probe(struct platform_device *pdev)

  static int xilinxfb_of_remove(struct platform_device *op)
  {
-	return xilinxfb_release(&op->dev);
+	xilinxfb_release(&op->dev);
+
+	return 0;
  }

  /* Match table for of_platform binding */

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux