On Tue, Oct 18, 2022 at 05:44:38PM -0700, John Harrison wrote: > On 10/12/2022 17:03, Daniele Ceraolo Spurio wrote: > > From: Aravind Iddamsetty <aravind.iddamsetty@xxxxxxxxx> > > ... > > diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/gt/intel_wopcm.c > > similarity index 86% > > rename from drivers/gpu/drm/i915/intel_wopcm.c > > rename to drivers/gpu/drm/i915/gt/intel_wopcm.c > > index 322fb9eeb880..487fbbbdf3d6 100644 > > --- a/drivers/gpu/drm/i915/intel_wopcm.c > > +++ b/drivers/gpu/drm/i915/gt/intel_wopcm.c > > @@ -43,6 +43,7 @@ > > /* Default WOPCM size is 2MB from Gen11, 1MB on previous platforms */ > > #define GEN11_WOPCM_SIZE SZ_2M > > #define GEN9_WOPCM_SIZE SZ_1M > > +#define XELPM_SAMEDIA_WOPCM_SIZE SZ_2M > XELPM? Isn't it just XELP? Xe_LP is the older TGL-ADL gfx IP name. MTL's media IP is called Xe_LPM+ (which we should label as XELPMP in code, so it looks like the final "P" is missing here). Matt -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation