On Tue, Oct 18, 2022 at 12:11:51PM -0400, Zack Rusin wrote: > From: Zack Rusin <zackr@xxxxxxxxxx> > > v2: Thomas and Laurent noticed that in radeon_fb.c I forgot to set the > info->apertures->ranges[0].base and Laurent noticed a neat little cleanup > in the hisilicon driver as a result of the drm_mode_config::fb_base > removal. You need to address LKP comment. > The fb_base in struct drm_mode_config has been unused for a long time. > Some drivers set it and some don't leading to a very confusing state > where the variable can't be relied upon, because there's no indication > as to which driver sets it and which doesn't. > > The only usage of fb_base is internal to two drivers so instead of trying > to force it into all the drivers to get it into a coherent state > completely remove it. ... > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -1778,7 +1778,6 @@ int ast_mode_config_init(struct ast_private *ast) > dev->mode_config.min_width = 0; > dev->mode_config.min_height = 0; > dev->mode_config.preferred_depth = 24; > - dev->mode_config.fb_base = pci_resource_start(pdev, 0); Unused pdev. > if (ast->chip == AST2100 || > ast->chip == AST2200 || I suggest to compile with `make W=1 C=1` on your side before sending v3 and address all compiler complaints. -- With Best Regards, Andy Shevchenko
