Hi Florian On Fri, Oct 14, 2022 at 12:43:38PM -0700, Florian Fainelli wrote: > On 10/13/22 02:13, Maxime Ripard wrote: > > A significant number of RaspberryPi drivers using the firmware don't > > have a phandle to it, so end up scanning the device tree to find a node > > with the firmware compatible. > > > > That code is duplicated everywhere, so let's introduce a helper instead. > > > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > --- > > drivers/firmware/raspberrypi.c | 7 +++++++ > > include/soc/bcm2835/raspberrypi-firmware.h | 7 +++++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c > > index 4b8978b254f9..b916e1e171f8 100644 > > --- a/drivers/firmware/raspberrypi.c > > +++ b/drivers/firmware/raspberrypi.c > > @@ -311,6 +311,13 @@ static int rpi_firmware_remove(struct platform_device *pdev) > > return 0; > > } > > +static const struct of_device_id rpi_firmware_of_match[]; > > This shadows the same variable that is used later for matching the firmware > driver and probe it as a platform_driver, what am I missing here? I'm not shadowing the variable, but it's a forward-declaration. Maxime
