Den 13.10.2022 15.18, skrev Maxime Ripard: > drm_connector_pick_cmdline_mode() is in charge of finding a proper > drm_display_mode from the definition we got in the video= command line > argument. > > Let's add some unit tests to make sure we're not getting any regressions > there. > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > --- > Changes in v5: > - Removed useless (for now) count and modes intermediate variables in > get_modes > - Switched to kunit assertions in test init, and to KUNIT_ASSERT_NOT_NULL > instead of KUNIT_ASSERT_PTR_NE(..., NULL) > > Changes in v4: > - Removed MODULE macros > --- > drivers/gpu/drm/drm_client_modeset.c | 4 + > drivers/gpu/drm/tests/drm_client_modeset_test.c | 99 +++++++++++++++++++++++++ > 2 files changed, 103 insertions(+) > > diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c > index bbc535cc50dd..d553e793e673 100644 > --- a/drivers/gpu/drm/drm_client_modeset.c > +++ b/drivers/gpu/drm/drm_client_modeset.c > @@ -1237,3 +1237,7 @@ int drm_client_modeset_dpms(struct drm_client_dev *client, int mode) > return ret; > } > EXPORT_SYMBOL(drm_client_modeset_dpms); > + > +#ifdef CONFIG_DRM_KUNIT_TEST > +#include "tests/drm_client_modeset_test.c" > +#endif I can't say I like including the file like this, but exporting the static function for testing isn't attractive either and doing it like this is shown in the kunit docs, so: Acked-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
