On Mon, 19 Sep 2022 09:49:07 -0700, Andi Shyti wrote: > > Hi Badal, Hi Andi, Badal is out for a bit so I am sending out this version. > On Mon, Sep 19, 2022 at 05:29:05PM +0530, Badal Nilawar wrote: > > Updated the CAGF functions to get actual resolved frequency of > > 3D and SAMedia > > can you please use the imperative form? "Update" and not > "Updated". > Besides I don't really understand what you did from the > commit, can you please bea bit more descriptive? Done in series version v5. Please take a look. > > Bspec: 66300 > > > > Cc: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx> > > Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> > > Signed-off-by: Badal Nilawar <badal.nilawar@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 8 ++++++++ > > drivers/gpu/drm/i915/gt/intel_rps.c | 6 +++++- > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > > index 2275ee47da95..7819d32db956 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > > @@ -1510,6 +1510,14 @@ > > #define VLV_RENDER_C0_COUNT _MMIO(0x138118) > > #define VLV_MEDIA_C0_COUNT _MMIO(0x13811c) > > > > +/* > > + * MTL: Workpoint reg to get Core C state and act freq of 3D, SAMedia/ > > + * 3D - 0x0C60 , SAMedia - 0x380C60 > > + * Intel uncore handler redirects transactions for SAMedia to MTL_MEDIA_GSI_BASE > > + */ > > This comment is not understandable... we don't have limits in > space, you can be a bit more explicit :) Based on Matt R's comment the comment has been deleted (except for the first line). There is an explanation at the bottom of gt/intel_gt_regs.h. Thanks. -- Ashutosh
