On Fri, 30 Sep 2022 09:52:28 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Tue, Sep 27, 2022 at 11:20:17AM +0530, Badal Nilawar wrote: > > From: Dale B Stimson <dale.b.stimson@xxxxxxxxx> > > > > Use i915 HWMON to display device level energy input. > > > > v2: Updated the date and kernel version in feature description > > v3: > > - Cleaned up hwm_energy function and removed unused function > > i915_hwmon_energy_status_get (Ashutosh) > > v4: KernelVersion: 6.2, Date: February 2023 in doc (Tvrtko) > > > > Signed-off-by: Dale B Stimson <dale.b.stimson@xxxxxxxxx> > > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> > > Signed-off-by: Riana Tauro <riana.tauro@xxxxxxxxx> > > Signed-off-by: Badal Nilawar <badal.nilawar@xxxxxxxxx> > > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> > > Reviewed-by: Anshuman Gupta <anshuman.gupta@xxxxxxxxx> > > --- > > .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ > > drivers/gpu/drm/i915/i915_hwmon.c | 107 +++++++++++++++++- > > drivers/gpu/drm/i915/intel_mchbar_regs.h | 2 + > > 3 files changed, 115 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index 16e697b1db3d..7525db243d74 100644 > > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > +++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > @@ -25,3 +25,11 @@ Contact: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Description: RO. Card default power limit (default TDP setting). > > > > Only supported for particular Intel i915 graphics platforms. > > + > > +What: /sys/devices/.../hwmon/hwmon<i>/energy1_input > > +Date: February 2023 > > +KernelVersion: 6.2 > > +Contact: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > I'm sorry for being late on the review here, and I know that others > already looked at the date and other details here in this doc. > So I'm curious why we have decided for the dri-devel mailing list > and not for the intel-gfx since intel-gfx is the only one we have > listed for i915 dir in the MAINTAINERS file: > L: intel-gfx@xxxxxxxxxxxxxxxxxxxxx I have changed the contact to intel-gfx@xxxxxxxxxxxxxxxxxxxxx in v9 for all patches. Thanks. -- Ashutosh
