Re: [PATCH] drm/i915/trace: Removed unused frequency trace

[Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>]

On 11/10/2022 14:59, Andi Shyti wrote:
> Commit 3e7abf814193 ("drm/i915: Extract GT render power state management")
> removes the "trace_intel_gpu_freq_change()" trace points but
> their definition was left without users. Remove it.
>
> Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/i915_trace.h | 15 ---------------
>   1 file changed, 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 37b5c9e9d260..c70a02517e02 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -671,21 +671,6 @@ TRACE_EVENT_CONDITION(i915_reg_rw,
>   		(u32)(__entry->val >> 32))
>   );
>   
> -TRACE_EVENT(intel_gpu_freq_change,
> -	    TP_PROTO(u32 freq),
> -	    TP_ARGS(freq),
> -
> -	    TP_STRUCT__entry(
> -			     __field(u32, freq)
> -			     ),
> -
> -	    TP_fast_assign(
> -			   __entry->freq = freq;
> -			   ),
> -
> -	    TP_printk("new_freq=%u", __entry->freq)
> -);
> -
>   /**
>    * DOC: i915_ppgtt_create and i915_ppgtt_release tracepoints
>    *

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Regards,

Tvrtko