On Thu, Oct 06, 2022 at 10:28:12PM +0200, Javier Martinez Canillas wrote:
> On 10/5/22 13:40, Thomas Zimmermann wrote:
> > Rename the atomic helper function drm_atomic_helper_check_crtc_state()
> > to drm_atomic_helper_check_crtc_primary_plane() and only check for an
> > attached primary plane. Adapt callers.
> >
> > Instead of having one big function to check for various CRTC state
> > conditions, we rather want smaller functions that drivers can pick
> > individually.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > ---
>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>
> [...]
>
> > + drm_for_each_plane_mask(plane, dev, crtc_state->plane_mask) {
> > + if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> > + return 0;
> > }
>
> I believe the code convention is to drop the curly braces when you
> have a single statement inside the a loop ?
This has two.
>
> Feel free to ignore it though. I particularly don't agree with that
> convention anyways, because I think that makes the code more error
> prone. But still thought that was worth to point that out.
>
> --
> Best regards,
>
> Javier Martinez Canillas
> Core Platforms
> Red Hat
--
Ville Syrjälä
Intel
