On 2022-10-04 17:29:32, Dmitry Baryshkov wrote: > On Sat, 1 Oct 2022 at 19:00, Marijn Suijten > <marijn.suijten@xxxxxxxxxxxxxx> wrote: > > [..] > > For sm6125 we also need this exact io_start (and a single PHY), do you > > think it makes sense to add a compatible that reuses the same struct (I > > can do that in a folloup patch) and/or generalize this struct (name)? > > > > However, our regulator setup appears to be different. I recall not > > finding any `vcca` supply in my downstream sources, and had this in my > > notes for a similar dsi_phy_14nm.c patch: > > > > sm6125 uses an RPM regulator > > > > https://github.com/sonyxperiadev/kernel/blob/f956fbd9a234033bd18234d456a2c32c126b38f3/arch/arm64/boot/dts/qcom/trinket-sde.dtsi#L388 > > I'd prefer a separate config for sm6125. This way you would be able to > add voting on the MX domain if required. Ack, I'll queue up a patch series for this SoC, with a dt-bindings patch that makes the vcca register optional for the sm6125 compatible. - Marijn
