On Sat, Oct 01, 2022 at 07:34:22PM -0300, Maíra Canal wrote: > The drm_test_dp_mst_sideband_msg_req_decode repeats the same test > structure with different parameters. This could be better represented > by parameterized tests, provided by KUnit. > > In addition to the parameterization of the tests, the test case for the > client ID was changed: instead of using get_random_bytes to generate > the client ID, the client ID is now hardcoded in the test case. This > doesn't affect the assertively of the tests, as this test case only compare > the data going in with the data going out and it doesn't transform the data > itself in any way. > > So, convert drm_test_dp_mst_sideband_msg_req_decode into parameterized > tests and make the tests' allocations and prints completely managed by KUnit. > > Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx> Reviewed-by: Michał Winiarski <michal.winiarski@xxxxxxxxx> Thanks! -Michał > --- > v1 -> v2: https://lore.kernel.org/dri-devel/20220925222719.345424-1-mcanal@xxxxxxxxxx/T/#m056610a23a63109484afeafefb5846178c4d36b2 > - Mention on the commit message the change on the test case for the client ID (Michał Winiarski). > > v2 -> v3: https://lore.kernel.org/dri-devel/20220927221206.55930-1-mcanal@xxxxxxxxxx/T/#m2dc961da2d4921566cd0f9a8ed9d2d33a1cf4416 > - Mention on the commit message that the "random" usage is not incompatible with parameterized tests (Michał Winiarski). > --- > .../gpu/drm/tests/drm_dp_mst_helper_test.c | 370 ++++++++++++------ > 1 file changed, 243 insertions(+), 127 deletions(-)
