On 29/09/2022 19:05, Diogo Ivo wrote:
> The Google Pixel C has a JDI LPM102A188A display panel. Add a
> DT node for it. Tested on Pixel C.
>
> Signed-off-by: Diogo Ivo <diogo.ivo@xxxxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index 20d092812984..271ef70747f1 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -31,6 +31,39 @@ memory {
> };
>
> host1x@50000000 {
> + dc@54200000 {
> + status = "okay";
You should override by labels, not by full path.
> + };
> +
> + dsia: dsi@54300000 {
> + avdd-dsi-csi-supply = <&vdd_dsi_csi>;
> + nvidia,boot-on;
> + status = "okay";
> +
> + link2: panel@0 {
> + compatible = "jdi,lpm102a188a";
> + reg = <0>;
> + };
> + };
> +
> + dsib: dsi@54400000 {
> + avdd-dsi-csi-supply = <&vdd_dsi_csi>;
> + nvidia,ganged-mode = <&dsia>;
> + nvidia,boot-on;
> + status = "okay";
> +
> + link1: panel@0 {
> + compatible = "jdi,lpm102a188a";
> + reg = <0>;
> + power-supply = <&pplcd_vdd>;
> + ddi-supply = <&pp1800_lcdio>;
> + enable-gpios = <&gpio TEGRA_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_LOW>;
> + link2 = <&link2>;
> + backlight = <&backlight>;
> + };
> + };
> +
> dpaux: dpaux@545c0000 {
> status = "okay";
> };
> @@ -1627,6 +1660,37 @@ nau8825@1a {
> status = "okay";
> };
>
> + backlight: lp8557-backlight@2c {
Node names should be generic: backlight
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,lp8557";
> + reg = <0x2c>;
> + power-supply = <&pplcd_vdd>;
> + enable-supply = <&pp1800_lcdio>;
> + bl-name = "lp8557-backlight";
> + dev-ctrl = /bits/ 8 <0x01>;
> + init-brt = /bits/ 8 <0x80>;
> +
> + /* Full scale current, 20mA */
> + rom_11h {
No underscores in node names, unless something requires it?
> + rom-addr = /bits/ 8 <0x11>;
> + rom-val = /bits/ 8 <0x05>;
> + };
Best regards,
Krzysztof
