On 9/19/22 15:03, Thomas Zimmermann wrote: > Set the USB control-message timeout to the USB default of 5 seconds. > Done for consistency with other uses of usb_control_msg() in udl and > other drivers. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- > drivers/gpu/drm/udl/udl_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index e9539829032c..cb3d6820eaf9 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -31,7 +31,7 @@ static int udl_get_edid_block(void *data, u8 *buf, unsigned int block, > int bval = (i + block * EDID_LENGTH) << 8; > ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > 0x02, (0x80 | (0x02 << 5)), bval, > - 0xA1, read_buff, 2, 1000); > + 0xA1, read_buff, 2, USB_CTRL_GET_TIMEOUT); Agreed, much better than an arbitrary 1 sec. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
