Re: [PATCH v2 2/4] drm: lcdif: Don't use BIT() for multi-bit register fields

[Liu Ying <victor.liu@xxxxxxxxxxx>]

On Wed, 2022-09-28 at 03:58 +0300, Laurent Pinchart wrote:
> The BIT() macro is meant to represent a single bit. Don't use it for
> values of register fields that span multiple bits.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> Changes since v1:
> 
> - Use hex for field values
> ---
>  drivers/gpu/drm/mxsfb/lcdif_regs.h | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

One option is to use FIELD_RPEP() macro for register field values.
But I think this patch is ok without using it, so:

Reviewed-by: Liu Ying <victor.liu@xxxxxxx>