On Wed, Sep 28, 2022 at 02:16:54AM +0200, Marek Vasut wrote:
> On 9/28/22 01:38, Laurent Pinchart wrote:
>
> Hi,
>
> [...]
>
> > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > index ba84b51598b3..a97a5f512aae 100644
> > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> > +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
>
> [...]
>
> > @@ -37,9 +38,10 @@ static void lcdif_set_formats(struct lcdif_drm_private *lcdif,
> > {
> > struct drm_device *drm = lcdif->drm;
> > const u32 format = lcdif->crtc.primary->state->fb->format->format;
> > + bool in_yuv = false;
> > + bool out_yuv = false;
> >
> > - writel(CSC0_CTRL_BYPASS, lcdif->base + LCDC_V8_CSC0_CTRL);
> > -
> > + /* HDMI output */
>
> Should this comment really be here ? The IP can be connected to either
> LVDS serializer/DSI bridge/HDMI , it is not just HDMI output IP.
You're right, I'll drop the comment.
> > switch (bus_format) {
> > case MEDIA_BUS_FMT_RGB565_1X16:
> > writel(DISP_PARA_LINE_PATTERN_RGB565,
>
> [...]
>
> Reviewed-by: Marek Vasut <marex@xxxxxxx>
--
Regards,
Laurent Pinchart
