Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

The change LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

I think we can use below fixes tag so that we can pick up this entire series for the fixes cycle.

Fixes: 3f0689e66352 ("drm/msm/dsi: check msm_dsi and dsi pointers before
use")

---
  drivers/gpu/drm/msm/dsi/dsi.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
index 8a95c744972a..31fdee2052be 100644
--- a/drivers/gpu/drm/msm/dsi/dsi.c
+++ b/drivers/gpu/drm/msm/dsi/dsi.c
@@ -211,14 +211,9 @@ void __exit msm_dsi_unregister(void)
  int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev,
  			 struct drm_encoder *encoder)
  {
-	struct msm_drm_private *priv;
+	struct msm_drm_private *priv = dev->dev_private;
  	int ret;
- if (WARN_ON(!encoder) || WARN_ON(!msm_dsi) || WARN_ON(!dev))
-		return -EINVAL;
-
-	priv = dev->dev_private;
-
  	if (priv->num_bridges == ARRAY_SIZE(priv->bridges)) {
  		DRM_DEV_ERROR(dev->dev, "too many bridges\n");
  		return -ENOSPC;



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux