Re: [PATCH -next] backlight: pwm_bl: Switch to use dev_err_probe() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2022/9/26 21:41, Daniel Thompson wrote:
On Mon, Sep 26, 2022 at 02:37:50PM +0100, Daniel Thompson wrote:
On Mon, Sep 26, 2022 at 09:32:58PM +0800, Yang Yingliang wrote:
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
I'd prefer to have received these patches as a patchset rather than
individual patches... but it is a good change so:

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
Oops. My last mail neglected to mention that you did not sign off your
changes (meaning we cannot accept them). When you re-send this please
add a SoB and combine with the other similar patches.
I missed -s when doing format-patch, I will add my SoB and your reivew tag in v2.

Thanks,
Yang


Daniel.
.



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux