Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



To whoom it may belong: Deepest sorrow to inform you that my husband Helmut passed by on July 21. This access will be cleared in a view days. 
Irene

-------- Ursprüngliche Nachricht --------
Von: Christian König <christian.koenig@xxxxxxx>
Datum: 01.09.22 08:50 (GMT+01:00)
An: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Gurchetan Singh <gurchetansingh@xxxxxxxxxxxx>, Chia-I Wu <olvaffe@xxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>, Gert Wollny <gert.wollny@xxxxxxxxxxxxx>, Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxx>, Daniel Stone <daniel@xxxxxxxxxxxxx>, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Rob Clark <robdclark@xxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Tomasz Figa <tfiga@xxxxxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, Thomas Hellström <thomas_os@xxxxxxxxxxxx>, Qiang Yu <yuq825@xxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Amol Maheshwari <amahesh@xxxxxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Tomi Valkeinen <tomba@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Lucas Stach <l.stach@xxxxxxxxxxxxxx>, Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Dmitry Osipenko <digetx@xxxxxxxxx>, linux-media@xxxxxxxxxxxxxxx, linaro-mm-sig@xxxxxxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx
Betreff: Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare Etnaviv driver to the common dynamic dma-buf locking convention
> by starting to use the unlocked versions of dma-buf API functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>

Interesting, where is the matching vmap()?

Anyway, this patch is Acked-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 3fa2da149639..7031db145a77 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -65,7 +65,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
>   struct iosys_map map = IOSYS_MAP_INIT_VADDR(etnaviv_obj->vaddr);
>  
>   if (etnaviv_obj->vaddr)
> - dma_buf_vunmap(etnaviv_obj->base.import_attach->dmabuf, &map);
> + dma_buf_vunmap_unlocked(etnaviv_obj->base.import_attach->dmabuf, &map);
>  
>   /* Don't drop the pages for imported dmabuf, as they are not
>   * ours, just free the array we allocated:


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux