On 26/09/2022 03:19, Jason-JH Lin (林睿祥) wrote:
> Hi Krzysztof,
>
> Thanks for the reviews.
>
> On Sun, 2022-09-25 at 09:52 +0200, Krzysztof Kozlowski wrote:
>> On 24/09/2022 10:00, Jason-JH.Lin wrote:
>>> For previous MediaTek SoCs, such as MT8173, there are 2 display HW
>>> pipelines binding to 1 mmsys with the same power domain, the same
>>> clock driver and the same mediatek-drm driver.
>>>
>>> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding
>>> to
>>> 2 different power domains, different clock drivers and different
>>> mediatek-drm drivers.
>>>
>>> Moreover, Hardware pipeline of VDOSYS0 has these components: COLOR,
>>> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture
>>> Quality)
>>> and they makes VDOSYS0 supports PQ function while they are not
>>> including in VDOSYS1.
>>>
>>> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR related
>>> component). It makes VDOSYS1 supports the HDR function while it's
>>> not
>>> including in VDOSYS0.
>>>
>>> To summarize0:
>>> Only VDOSYS0 can support PQ adjustment.
>>> Only VDOSYS1 can support HDR adjustment.
>>>
>>> Therefore, we need to separate these two different mmsys hardwares
>>> to
>>> 2 different compatibles for MT8195.
>>>
>>> Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add mt8195
>>> SoC binding")
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
>>> Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx>
>>> ---
>>> .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 5
>>> ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
>>> l
>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
>>> l
>>> index 6ad023eec193..4f90ea03c596 100644
>>> ---
>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
>>> l
>>> +++
>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
>>> l
>>> @@ -31,13 +31,16 @@ properties:
>>> - mediatek,mt8183-mmsys
>>> - mediatek,mt8186-mmsys
>>> - mediatek,mt8192-mmsys
>>> - - mediatek,mt8195-mmsys
>>
>> We keep making circles...
>
> I didn't find the sample of "deprecated" in the example-schema.yaml,
> so I keep misunderstand what you mean.
> I'm sorry about that...
>
>>
>> I asked "and why mediatek,mt8195-mmsys is kept as non-deprecated?"
>>
> Yes, it should be deprecated. I shouldn't remove it...
>
>> and your response is to remove it... Eh, okay, that's fine but now
>> your
>> change causes now warnings in existing DTS. Either you keep old entry
>> as
>> deprecated (just git grep for deprecated, you will find examples how
>> to
>> do it) or fix the DTS.
>>
> Thanks for the advice.
>
> Now I found an example in other yaml, so I just added the "deprecated"
> tag like this, right?
>
> - items:
> - enum:
> - mediatek,mt2701-mmsys
> - mediatek,mt2712-mmsys
> - mediatek,mt6765-mmsys
> - mediatek,mt6779-mmsys
> - mediatek,mt6797-mmsys
> - mediatek,mt8167-mmsys
> - mediatek,mt8173-mmsys
> - mediatek,mt8183-mmsys
> - mediatek,mt8186-mmsys
> - mediatek,mt8192-mmsys
> - mediatek,mt8195-mmsys
> deprecated: true
No, you need oneOf. You used git grep, good. Now use second command -
git log -p - to see how it was exactly added...
Best regards,
Krzysztof
