On Thu, Sep 22, 2022 <cgel.zte@xxxxxxxxx> wrote: > > From: ye xingchen <ye.xingchen@xxxxxxxxxx> > > Replace the open-code with sysfs_emit() to simplify the code. > > Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> Acked-by: Jingoo Han <jingoohan1@xxxxxxxxx> Best regards, Jingoo Han > --- > drivers/video/backlight/lm3533_bl.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c > index 1df1b6643c0b..5e2ce9285245 100644 > --- a/drivers/video/backlight/lm3533_bl.c > +++ b/drivers/video/backlight/lm3533_bl.c > @@ -66,7 +66,7 @@ static ssize_t show_id(struct device *dev, > { > struct lm3533_bl *bl = dev_get_drvdata(dev); > > - return scnprintf(buf, PAGE_SIZE, "%d\n", bl->id); > + return sysfs_emit(buf, "%d\n", bl->id); > } > > static ssize_t show_als_channel(struct device *dev, > @@ -75,7 +75,7 @@ static ssize_t show_als_channel(struct device *dev, > struct lm3533_bl *bl = dev_get_drvdata(dev); > unsigned channel = lm3533_bl_get_ctrlbank_id(bl); > > - return scnprintf(buf, PAGE_SIZE, "%u\n", channel); > + return sysfs_emit(buf, "%u\n", channel); > } > > static ssize_t show_als_en(struct device *dev, > @@ -95,7 +95,7 @@ static ssize_t show_als_en(struct device *dev, > mask = 1 << (2 * ctrlbank); > enable = val & mask; > > - return scnprintf(buf, PAGE_SIZE, "%d\n", enable); > + return sysfs_emit(buf, "%d\n", enable); > } > > static ssize_t store_als_en(struct device *dev, > @@ -147,7 +147,7 @@ static ssize_t show_linear(struct device *dev, > else > linear = 0; > > - return scnprintf(buf, PAGE_SIZE, "%x\n", linear); > + return sysfs_emit(buf, "%x\n", linear); > } > > static ssize_t store_linear(struct device *dev, > @@ -190,7 +190,7 @@ static ssize_t show_pwm(struct device *dev, > if (ret) > return ret; > > - return scnprintf(buf, PAGE_SIZE, "%u\n", val); > + return sysfs_emit(buf, "%u\n", val); > } > > static ssize_t store_pwm(struct device *dev, > -- > 2.25.1