On 22/09/2022 12:30, Dmitry Baryshkov wrote:
>>> + display-subsystem@ae00000 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "qcom,sc7180-mdss";
>>> + reg = <0xae00000 0x1000>;
>>> + reg-names = "mdss";
>>> + power-domains = <&dispcc MDSS_GDSC>;
>>> + clocks = <&gcc GCC_DISP_AHB_CLK>,
>>> + <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>> + <&dispcc DISP_CC_MDSS_MDP_CLK>;
>>> + clock-names = "iface", "ahb", "core";
>>> +
>>> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <1>;
>>> +
>>> + interconnects = <&mmss_noc MASTER_MDP0 &mc_virt SLAVE_EBI1>;
>>> + interconnect-names = "mdp0-mem";
>>> +
>>> + iommus = <&apps_smmu 0x800 0x2>;
>>> + ranges;
>>
>> This should come with full example, so with display-controller child
>> (unless Rob asked not to?)
>
> I'm not sure here. We have an example of a display-controller in a
> separate schema file. Why would you like to duplicate it?
To validate the child node (display-controller) in the context of this
schema. The child node is essential, so I would also say that example is
incomplete.
Best regards,
Krzysztof
