Re: [PATCH v2 10/10] drm/ofdrm: Support color management

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Hi

Am 22.09.22 um 09:28 schrieb Maxime Ripard:
> On Thu, Sep 22, 2022 at 08:42:23AM +0200, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 21.09.22 um 18:48 schrieb Geert Uytterhoeven:
> > > Hi Thomas,
> > >
> > > On Wed, Sep 21, 2022 at 2:55 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> > > > Am 05.08.22 um 02:19 schrieb Benjamin Herrenschmidt:
> > > > > On Wed, 2022-07-20 at 16:27 +0200, Thomas Zimmermann wrote:
> > > > > > +#if !defined(CONFIG_PPC)
> > > > > > +static inline void out_8(void __iomem *addr, int val)
> > > > > > +{ }
> > > > > > +static inline void out_le32(void __iomem *addr, int val)
> > > > > > +{ }
> > > > > > +static inline unsigned int in_le32(const void __iomem *addr)
> > > > > > +{
> > > > > > +       return 0;
> > > > > > +}
> > > > > > +#endif
> > > > >
> > > > > These guys could just be replaced with readb/writel/readl respectively
> > > > > (beware of the argument swap).
> > > >
> > > > I only added them for COMPILE_TEST. There appears to be no portable
> > > > interface that implements out_le32() and in_le32()?
> > >
> > > iowrite32() and ioread32()?
> >
> > Do they always use little endian, as these *_le32 helpers do? I though they
> > use host byte order.
>
> They use either outl or writel under the hood, which are always little-endian

I see. I'll replace the custom helpers.

Best regards
Thomas

> Maxime

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature