[AMD Official Use Only - General] Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > -----Original Message----- > From: Li Zhong <floridsleeves@xxxxxxxxx> > Sent: Thursday, September 22, 2022 12:18 PM > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: jiapeng.chong@xxxxxxxxxxxxxxxxx; Powell, Darren > <Darren.Powell@xxxxxxx>; Chen, Guchun <Guchun.Chen@xxxxxxx>; > Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Quan, Evan > <Evan.Quan@xxxxxxx>; Lazar, Lijo <Lijo.Lazar@xxxxxxx>; daniel@xxxxxxxx; > airlied@xxxxxxxx; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; Koenig, Christian > <Christian.Koenig@xxxxxxx>; Deucher, Alexander > <Alexander.Deucher@xxxxxxx>; Li Zhong <floridsleeves@xxxxxxxxx> > Subject: [PATCH v2] drivers/amd/pm: check the return value of > amdgpu_bo_kmap > > amdgpu_bo_kmap() returns error when fails to map buffer object. Add the > error check and propagate the error. > > Signed-off-by: Li Zhong <floridsleeves@xxxxxxxxx> > --- > drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > index 1eb4e613b27a..ec055858eb95 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c > @@ -1485,6 +1485,7 @@ static int pp_get_prv_buffer_details(void *handle, > void **addr, size_t *size) > { > struct pp_hwmgr *hwmgr = handle; > struct amdgpu_device *adev = hwmgr->adev; > + int err; > > if (!addr || !size) > return -EINVAL; > @@ -1492,7 +1493,9 @@ static int pp_get_prv_buffer_details(void *handle, > void **addr, size_t *size) > *addr = NULL; > *size = 0; > if (adev->pm.smu_prv_buffer) { > - amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr); > + err = amdgpu_bo_kmap(adev->pm.smu_prv_buffer, addr); > + if (err) > + return err; > *size = adev->pm.smu_prv_buffer_size; > } > > -- > 2.25.1