Tentative r-b, but we *do* need to make a decision on how we want to handle endianness. I don't have strong feelings but the results of that discussion should go in the commit message. On Tue, Sep 20, 2022 at 10:15:45PM +0100, Adri??n Larumbe wrote: > __le32 and __l64 endian-specific types aren't portable and not available on > FreeBSD, for which there's a uAPI compatible reimplementation of Panfrost. > > Replace these specific types with more generic unsigned ones, to prevent > FreeBSD Mesa build errors. > > Bug: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7252 > Fixes: 730c2bf4ad39 ("drm/panfrost: Add support for devcoredump") > Signed-off-by: Adri??n Larumbe <adrian.larumbe@xxxxxxxxxxxxx> > --- > include/uapi/drm/panfrost_drm.h | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h > index bd77254be121..c1a10a9366a9 100644 > --- a/include/uapi/drm/panfrost_drm.h > +++ b/include/uapi/drm/panfrost_drm.h > @@ -236,24 +236,24 @@ struct drm_panfrost_madvise { > #define PANFROSTDUMP_BUF_TRAILER (PANFROSTDUMP_BUF_BO + 1) > > struct panfrost_dump_object_header { > - __le32 magic; > - __le32 type; > - __le32 file_size; > - __le32 file_offset; > + __u32 magic; > + __u32 type; > + __u32 file_size; > + __u32 file_offset; > > union { > struct { > - __le64 jc; > - __le32 gpu_id; > - __le32 major; > - __le32 minor; > - __le64 nbos; > + __u64 jc; > + __u32 gpu_id; > + __u32 major; > + __u32 minor; > + __u64 nbos; > } reghdr; > > struct { > - __le32 valid; > - __le64 iova; > - __le32 data[2]; > + __u32 valid; > + __u64 iova; > + __u32 data[2]; > } bomap; > > /* > @@ -261,14 +261,14 @@ struct panfrost_dump_object_header { > * with new fields and also keep it 512-byte aligned > */ > > - __le32 sizer[496]; > + __u32 sizer[496]; > }; > }; > > /* Registers object, an array of these */ > struct panfrost_dump_registers { > - __le32 reg; > - __le32 value; > + __u32 reg; > + __u32 value; > }; > > #if defined(__cplusplus) > -- > 2.37.0 >
