On 2022/9/19 9:41, Zeng Heng wrote: > Fix below compile warning when open enum-conversion > option check (compiled with -Wenum-conversion): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: > In function ‘dml20_ModeSupportAndSystemConfigurationFull’: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3900:44: > error: implicit conversion from ‘enum <anonymous>’ to ‘enum odm_combine_mode’ [-Werror=enum-conversion] > 3900 | locals->ODMCombineEnablePerState[i][k] = false; > | ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3904:46: > error: implicit conversion from ‘enum <anonymous>’ to ‘enum odm_combine_mode’ [-Werror=enum-conversion] > 3904 | locals->ODMCombineEnablePerState[i][k] = true; > | ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3907:46: > error: implicit conversion from ‘enum <anonymous>’ to ‘enum odm_combine_mode’ [-Werror=enum-conversion] > 3907 | locals->ODMCombineEnablePerState[i][k] = true; > | ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c:3960:45: > error: implicit conversion from ‘enum <anonymous>’ to ‘enum odm_combine_mode’ [-Werror=enum-conversion] > 3960 | locals->ODMCombineEnablePerState[i][k] = false; > > Use the proper value from the right enumerated type, > dm_odm_combine_mode_disabled & dm_odm_combine_mode_2to1, > so there is no more implicit conversion. > > The numerical values of dm_odm_combine_mode_disabled > & false and dm_odm_combine_mode_2to1 & true > happen to be the same, so there is no change in > behavior. > LGTM
