On Fri, Sep 09, 2022 at 11:31:16AM +0200, Maxime Ripard wrote:
> Commit ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
> has introduced a call to drm_atomic_get_new_crtc_state(), but didn't
> include drm_atomic.h.
>
> On CONFIG_OF systems, this is fine because drm_atomic.h is included by
> drm_of.h through drm_bridge.h. However, whenever CONFIG_OF isn't set, we
> end up with a compilation error.
>
> Fixes: ec491291dc94 ("drm/sun4i: tv: Merge mode_set into atomic_enable")
> Reported-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
Also caught by the robot since then:
https://lists.freedesktop.org/archives/dri-devel/2022-September/371257.html
Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/sun4i/sun4i_tv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
> index 74ff5ad6a8b9..c65f0a89b6b0 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_tv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
> @@ -14,6 +14,7 @@
> #include <linux/regmap.h>
> #include <linux/reset.h>
>
> +#include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_of.h>
> #include <drm/drm_panel.h>
> --
> 2.37.1
--
Ville Syrjälä
Intel
