Re: [PATCH v2 4/5] drm/msm/hdmi: don't take extra reference on PHY device

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote:
> The of_find_device_by_node() already increments the device's usage
> count, so there is no need to increment it again using get_device().
> Drop this extra get_device().
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index c298a36f3b42..926274eeee25 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -106,7 +106,7 @@ static int msm_hdmi_get_phy(struct hdmi *hdmi)
>   		return -EPROBE_DEFER;
>   	}
>   
> -	hdmi->phy_dev = get_device(&phy_pdev->dev);
> +	hdmi->phy_dev = &phy_pdev->dev;
>   
>   	return 0;
>   }