On Mon, Sep 05, 2022 at 03:09:05PM -0700, Guenter Roeck wrote:
> On 9/5/22 12:47, Dmitry Torokhov wrote:
> [ ... ]
> > > We know that count is either 1 or 2 here, so strictly speaking
> > > if (count == 1) {
> > > } else {
> > > }
> > > would be sufficient. On the other side, that depends on ARRAY_SIZE() being
> > > exactly 2, so
> > > if (count == 1) {
> > > } else if (count == 2) {
> > > }
> > > would also make sense. Either way is fine with me. I'll leave it up
> > > to Dmitry to decide what he wants to do.
> >
> > My goal is to drop usage of devm_gpiod_get_from_of_node(), beyond that I
> > do not have strong preferences either way really. It is probing code, so
> > performance is not critical, but I'm obviously satisfied with how the
> > code looks now, or I would not have sent it.
> >
>
> Good point.
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Guenter, individual patches are going through maintainer's trees, will
you take this one?
Thanks.
--
Dmitry
