On Thu, Jul 28, 2022 at 09:47:56AM +0200, Thomas Zimmermann wrote: > Call drm_plane_enable_fb_damage_clips() and give userspace a chance > of minimizing the updated display area. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- > drivers/gpu/drm/udl/udl_modeset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c > index e67c40a48fb4..ce427128f034 100644 > --- a/drivers/gpu/drm/udl/udl_modeset.c > +++ b/drivers/gpu/drm/udl/udl_modeset.c > @@ -479,6 +479,7 @@ int udl_modeset_init(struct drm_device *dev) > format_count, NULL, connector); > if (ret) > return ret; > + drm_plane_enable_fb_damage_clips(&udl->display_pipe.plane); I'm assuming this passes with all the igts we have (I hope those finally landed) and a damage-capable compositor doesn't go boom either? Either way patch lgtm. Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> Also I wonder whether we should have a check in the damage helpers to make sure drivers don't forget to call this function to set up the uapi ... Cheers, Daniel > > drm_mode_config_reset(dev); > > -- > 2.37.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
