Hi Krzysztof, Thanks for your review, and appreciate for all comments and sugestions. I misunderstanding enum and const usage. I'll add another item for mt8188 at next version. On Tue, 2022-08-23 at 15:51 +0300, Krzysztof Kozlowski wrote: > On 22/08/2022 06:32, nathan.lu wrote: > > From: Nathan Lu <nathan.lu@xxxxxxxxxxxx> > > > > modify VDOSYS0 device tree Documentations for MT8188. > > (...) > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. > > yaml > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. > > yaml > > index 0882ae86e6c4..d0e6c0dd4dfb 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. > > yaml > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. > > yaml > > @@ -30,6 +30,8 @@ properties: > > - items: > > - const: mediatek,mt8183-disp-rdma > > - items: > > + - enum: > > + - mediatek,mt8188-disp-rdma > > - const: mediatek,mt8195-disp-rdma > > Why do you change existing bindings? > > Best regards, > Krzysztof
