On Tue, Aug 30, 2022 at 09:31:54AM +0200, Vitaly Kuznetsov wrote: > Bjorn Helgaas <helgaas@xxxxxxxxxx> writes: > > > On Sat, Aug 27, 2022 at 03:03:43PM +0200, Vitaly Kuznetsov wrote: > >> There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT > >> and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these > >> from core Vmbus code. Move the defines where they belong. > > > > It's a minor annoyance that the above is 81 characters long when "git > > log" adds its 4-character indent, so it wraps in a default terminal. > > > > It'd be nice if we could settle on a conventional spelling of "Vmbus", > > too. "Vmbus" looks to be in the minority: > > > > $ git grep Vmbus | wc -l; git grep VMbus | wc -l; git grep VMBus | wc -l > > 4 > > 82 > > 62 > > > > FWIW, one published microsoft.com doc uses "VMBus": > > https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/reference/hyper-v-architecture > > Makes sense, > > Wei, > > assuming there are no other concerns about these patches, would you be > able to tweak the commit message here when queueing or would you like me > to send v4 instead? I can do the tweaking. Don't bother sending v4 if there is no other concern. Thanks, Wei. > > Thanks! > > -- > Vitaly >
